![]() Keep up the great work.Īs the sibling comment says, horizontal scrolling would be an improvement over the status quo. Lots of cool stuff you can do if you fully-leverage the mobile device environment and related user knowledge.īTW, I love the direction all of this is headed in. Swipe left on a diff region for deeper review, swipe right for approval. ![]() Instead of trying to display the full diff all at once for a file, perhaps you aggregate the diff regions, and then display those one-at-a-time. I feel if you could support some approach where the text item is displayed at full scale always (no line break/wrapping), and the user can basically treat the view like they would an image (pinch-to-zoom/pan).Īdditionally, perhaps the code review process on mobile could be somewhat different from the desktop experience. Swiping left/right and pinching to zoom are the very first things I tried when reviewing a PR. It is very intuitive for a mobile device user to swipe left/right in order to scroll content that is obviously clipped by the screen dimensions. I feel for text wrapping, letting it simply flow off the device screen works well in this UX scenario because all of these devices should be expected to be multi-touch enabled. ![]() So, having the app is an improvement over the mobile web experience (particularly since the PR review approval button was impossible to hit in the mobile web view without zooming), but IMO there's still a lot to be done here, and I hope they keep executing on it. If you follow a link to particular issue comment (for example, from the bottom of a notification email), the Android app will just land you at the top of the issue. The main activity feed from / is nowhere to be seen, even though this is something I use daily on my laptops (long-standing pet peeve, since this is also non-existent in the mobile web view). The support for per-commit code review (which is only so-so in the desktop web experience) is even harder to use on mobile. I've been using betas for the Android app, but in my experience there's still a lot of paper cuts here.įor example, I do quite a few code reviews on my Pixel 2, but what drives me crazy is that the lines in the diffs wrap! On top of that, the code font it uses is pretty large, so wrapping happens often and makes reviewing much harder.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |